You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dmitrylavrenov
changed the title
Remove already applied pallet_multisig::migrations::v1::MigrateToV1 migration
Remove already applied pallet_multisig::migrations::v1::MigrateToV1 at humanode-runtime migrations scope
Mar 24, 2025
This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful.
This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.
This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful. This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.
Yep, that's why the following rework was introduced - #1315 to unify the whole migrations scope.
This is actually interesting, and finally forces some pattern on the migrations management: remove them as soon as they're no longer useful. This leads to some a set of complications and new things we have to keep an account for. Let's create an issue to discuss and think this through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dmitrylavrenov
changed the title
try-runtimechecks at ci throw error nowcalled Result::unwrap() on an Err value: Other("this migration can be deleted")after executed runtime upgrade at mainnet to 127 due to https://github.com/humanode-network/substrate/blob/8afcafd721d31939e4dee7b779f152ab9eb1c8be/frame/multisig/src/migrations.rs#L49#1498 has faced this error. So, probably, we should remove it now.
Btw, I don't think that
pallet_multisig::migrationsshould throw error for this logic atpre_upgradeimplementation.